improve: moving some integration test into packages, some @Sample cleanup #3119
+2
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anup Having those tests in packages gives better visibility on webpage. Removing sample from two tests, which does not demonstrate functionlity, rather just tests some cases. Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
sample-improve
branch
from
4727610 to
384778a
Compare
xstefank
approved these changes
Jan 14, 2026
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
Why remove Sample annotations?
Collaborator
Author
The intention is to have samples which are user facing, describe some use case, from integration tests which are really just testing some aspect of the framework. For example concurrency tests are not really useful for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having those tests in packages gives better visibility on webpage.
Removing sample from two tests, which does not demonstrate functionlity, rather just tests some cases.
Signed-off-by: Attila Mészáros [email protected]